Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2658: Switch from = to == operator when querying for holdings-storage #2336

Merged
merged 8 commits into from
Nov 8, 2023
Merged

UIIN-2658: Switch from = to == operator when querying for holdings-storage #2336

merged 8 commits into from
Nov 8, 2023

Conversation

mkuklis
Copy link
Contributor

@mkuklis mkuklis commented Nov 7, 2023

https://issues.folio.org/browse/UIIN-2658

The = operator was taking too long to finish in Poppy.

This PR switched from = to == operator when querying for holdings-storage/holdings by hrids.

@mkuklis mkuklis changed the title UIIN-2658: Switch from = to == operator when quering for holdings-storage UIIN-2658: Switch from = to == operator when querying for holdings-storage Nov 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0  228 suites  ±0   10m 32s ⏱️ - 4m 38s
901 tests ±0  899 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
906 runs  ±0  904 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 136be69. ± Comparison against base commit 864ac3d.

♻️ This comment has been updated with latest results.

MikeTaylor
MikeTaylor approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@MikeTaylor MikeTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

mariia-aloshyna
mariia-aloshyna reviewed Nov 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MikeTaylor
Copy link
Contributor

Probably needs a few more merge-from-master events before this is ready :-)

@mkuklis mkuklis merged commit 6dd0fa8 into master Nov 8, 2023
4 checks passed
mariia-aloshyna pushed a commit that referenced this pull request Nov 8, 2023
@mkuklis @mariia-aloshyna
UIIN-2658: Switch from = to == operator when querying for holdings-st…
2a04d74 
…orage (#2336)

* UIIN-2658: Switch from = to == operator when quering for holdings-storage/holdings

* Fix typo

* Update changelog

* Cleanup

* Update changelogs

(cherry picked from commit 6dd0fa8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariia-aloshyna mariia-aloshyna mariia-aloshyna left review comments

@MikeTaylor MikeTaylor MikeTaylor approved these changes

@maccabeelevine maccabeelevine Awaiting requested review from maccabeelevine

@nielserik nielserik Awaiting requested review from nielserik

@BogdanDenis BogdanDenis Awaiting requested review from BogdanDenis

@Dmytro-Melnyshyn Dmytro-Melnyshyn Awaiting requested review from Dmytro-Melnyshyn

@OleksandrHladchenko1 OleksandrHladchenko1 Awaiting requested review from OleksandrHladchenko1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkuklis @MikeTaylor @mariia-aloshyna