Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2647: Share instance when there are no linked MARC Authorities (follow-up) #2337

Merged
merged 14 commits into from
Nov 7, 2023
Merged

UIIN-2647: Share instance when there are no linked MARC Authorities (follow-up) #2337

merged 14 commits into from
Nov 7, 2023

Conversation

OleksandrHladchenko1
Copy link
Contributor

Approach

  • If there are no linked MARC Authorities => proceed with sharing.
  • If there is at least one local linked MARC Authority => show another modal to proceed sharing with unlinking MARC Authorities.
  • If there are only shared linked MARC Authorities => proceed with sharing.

Refs

UIIN-2647

BogdanDenis
BogdanDenis requested changes Nov 7, 2023
View reviewed changes
src/ViewInstance.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0  228 suites  ±0   15m 4s ⏱️ +5s
899 tests ±0  897 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
904 runs  ±0  902 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a5e023a. ± Comparison against base commit c4faa0c.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 3e59803 into master Nov 7, 2023
4 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-2647 branch November 7, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@Dmytro-Melnyshyn Dmytro-Melnyshyn Awaiting requested review from Dmytro-Melnyshyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @BogdanDenis @mariia-aloshyna