Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2682: Handle errors correctly when sharing local instances failed #2341

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

mariia-aloshyna
Copy link
Contributor

Purpose

  • Adjust handling of failed requests

Approach

  • Create renderInstanceDetails to render details conditionally and have only one Callout component in the tree
  • Handle errors when fetching MARC authorities

Refs

https://issues.folio.org/browse/UIIN-2682

Screenshots

Copy link

github-actions bot commented Nov 9, 2023

Jest Unit Test Statistics

    1 files  ±0  228 suites  ±0   15m 25s ⏱️ +30s
903 tests ±0  901 ✔️ ±0  2 💤 ±0  0 ±0 
908 runs  ±0  906 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 679f468. ± Comparison against base commit ae7adba.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.3% 85.3% Coverage
0.0% 0.0% Duplication

@mariia-aloshyna mariia-aloshyna merged commit 77ef1de into master Nov 9, 2023
4 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIIN-2682 branch November 9, 2023 15:12
mariia-aloshyna added a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants