Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2690 Don't render Fast Add record modal in a <Paneset> to re-calculate other <Pane>'s widths after closing #2347

Merged
merged 3 commits into from
Nov 16, 2023
Merged

UIIN-2690 Don't render Fast Add record modal in a <Paneset> to re-calculate other <Pane>'s widths after closing #2347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b65b767
UIIN-2690 Don't render Fast Add record modal in a `<Paneset>` to re-c…
BogdanDenis Nov 14, 2023
8c53501
Merge remote-tracking branch 'origin/master' into UIIN-2690
BogdanDenis Nov 14, 2023
7be0c18
Merge branch 'master' into UIIN-2690
BogdanDenis Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* Updated translations for adding new Instance records. Refs UIIN-2630.
* Inactive Holdings/items on Central tenant when user have affiliation for separate Member with 0 permissions. Fixes UIIN-2689.
* Ignored hot key command on edit fields. Refs UIIN-2604.
* Don't render Fast Add record modal in a `<Paneset>` to re-calculate other `<Pane>`'s widths after closing. Fixes UIIN-2690.

## [10.0.4](https://github.com/folio-org/ui-inventory/tree/v10.0.4) (2023-11-10)
[Full Changelog](https://github.com/folio-org/ui-inventory/compare/v10.0.3...v10.0.4)
Expand Down
1 change: 1 addition & 0 deletions src/components/InstancesList/InstancesList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@
setSegmentSortBy = (sortBy) => {
const { segment } = this.props;

const segmentsSortBy = this.state.segmentsSortBy.map((key) => {

Check failure on line 655 in src/components/InstancesList/InstancesList.js

View workflow job for this annotation

GitHub Actions / github-actions-ci 

Use callback in setState when referencing the previous state

Check failure on line 655 in src/components/InstancesList/InstancesList.js

View workflow job for this annotation

GitHub Actions / github-actions-ci 

Use callback in setState when referencing the previous state
if (key.name === segment) {
key.sort = sortBy;
return key;
Expand Down Expand Up @@ -733,6 +733,7 @@
<Pluggable
id="clickable-create-inventory-records"
onClose={this.handleFastAddModalClose}
renderInPaneset={false}
open={this.state.showNewFastAddModal} // control the open modal via state var
renderTrigger={() => (
this.getActionItem({
Expand Down
Loading