Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2267: Browse Lists | Focus updates #2362

Merged
merged 5 commits into from
Nov 30, 2023
Merged

UIIN-2267: Browse Lists | Focus updates #2362

merged 5 commits into from
Nov 30, 2023

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Nov 28, 2023 •
edited
Loading

Purpose

  • after clicking on the Browse toggle shift focus to the Browse search options dropdown;
  • after hitting the Search button shift focus on the results pane header;
  • after clicking on a Browse record name displayed in the first column shift focus to the Instance search results list pane header;
  • after clicking Previous and Next pagination shift focus to first result on page.

Approach

Refs

UIIN-2267

Screenshots

2023-11-29_15h50_57.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0  228 suites  ±0   15m 14s ⏱️ +12s
909 tests +3  907 ✔️ +3  2 💤 ±0  0 ❌ ±0 
914 runs  +3  912 ✔️ +3  2 💤 ±0  0 ❌ ±0 

Results for commit d487c20. ± Comparison against base commit b6a3b3b.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from mariia-aloshyna and a team and removed request for a team, BogdanDenis and mariia-aloshyna November 28, 2023 21:08
@Dmytro-Melnyshyn Dmytro-Melnyshyn marked this pull request as draft November 29, 2023 08:22
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Dmytro-Melnyshyn Dmytro-Melnyshyn marked this pull request as ready for review November 29, 2023 13:48
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team November 30, 2023 08:19
@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 6f96fbe into master Nov 30, 2023
4 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIIN-2267 branch November 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

@ryandberger ryandberger ryandberger approved these changes

@BogdanDenis BogdanDenis Awaiting requested review from BogdanDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dmytro-Melnyshyn @ryandberger @mariia-aloshyna