UIIN-2716 Refactor CSS away from postcss-color-function #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuklis
approved these changes
Dec 6, 2023
BogdanDenis
approved these changes
Dec 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.folio.org/browse/UIIN-2716
We're on a mission to remove an out-of-date dependency of our CSS pipeline,
postcss-color-function.color()as we used it, was removed from its proposal and ultimately changed in native CSS API to convert color spaces rather than blend colors.The functionality has been replaced via the
color-mix()function as well as the new relative-color-syntax. This PR uses both.The colors are a very near match..
This relates back, but is only blocked by folio-org/stripes-webpack#133 for firefox support.