-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIIN-2546/UIIN-2548/UIIN-2549/UIIN-2556/UIIN-2557 Number generator implementation #2408
Open
EthanFreestone
wants to merge
28
commits into
master
Choose a base branch
from
feat/number-generator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+706
−16
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
206be77
feat: Number Generator (Settings)
EthanFreestone e939a79
feat: Wired up settings to ItemForm
EthanFreestone 575f064
feat: ItemForm
EthanFreestone f7e643a
refactor: Tweaks
EthanFreestone 5f33597
chore: Translation
EthanFreestone 23f0456
feat: Safety
EthanFreestone 8e76340
style: Grey out disabled radio buttons
EthanFreestone e9024df
chore: Slight tweaks
EthanFreestone e5cebd6
feat: Styling tweaks
EthanFreestone 685ebae
style: Padding
EthanFreestone e1a9baa
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone 9e202b8
build: OptionalOkapiInterfaces
EthanFreestone 391442e
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone 657d272
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone 3592bab
feat: Holdings
EthanFreestone beec654
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone 65fbd3e
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone d2728a4
chore: Button UX
EthanFreestone 0bf7177
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone 2702209
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone 00644eb
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone 2f1cab6
refactor: Settings order
EthanFreestone a1320ae
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone 1eb29eb
chore: Linting and test fixes
EthanFreestone 8381957
test: More tests and mocks to try and push PR through
EthanFreestone 29c9b5c
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone ea9eccf
build: Change service interaction dependency to ^3.0.0
EthanFreestone b0a16b6
chore: Removed "Learn more" button
EthanFreestone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
chore: Removed "Learn more" button
commit b0a16b667e11780bd9dca40b4cdbc95338d493fb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setSegmentSortBy = (sortBy) => { | ||
const { segment } = this.props; | ||
const segmentsSortBy = this.state.segmentsSortBy.map((key) => { | ||
if (key.name === segment) { | ||
key.sort = sortBy; | ||
return key; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, cover this component with unit tests