Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2546/UIIN-2548/UIIN-2549/UIIN-2556/UIIN-2557 Number generator implementation #2408

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
206be77
feat: Number Generator (Settings)
EthanFreestone Mar 3, 2023
e939a79
feat: Wired up settings to ItemForm
EthanFreestone Mar 10, 2023
575f064
feat: ItemForm
EthanFreestone Mar 10, 2023
f7e643a
refactor: Tweaks
EthanFreestone Mar 23, 2023
5f33597
chore: Translation
EthanFreestone Mar 23, 2023
23f0456
feat: Safety
EthanFreestone Mar 23, 2023
8e76340
style: Grey out disabled radio buttons
EthanFreestone Mar 23, 2023
e9024df
chore: Slight tweaks
EthanFreestone Apr 21, 2023
e5cebd6
feat: Styling tweaks
EthanFreestone May 11, 2023
685ebae
style: Padding
EthanFreestone May 11, 2023
e1a9baa
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Jun 20, 2023
9e202b8
build: OptionalOkapiInterfaces
EthanFreestone Jun 20, 2023
391442e
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Aug 7, 2023
657d272
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Aug 21, 2023
3592bab
feat: Holdings
EthanFreestone Sep 1, 2023
beec654
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Sep 1, 2023
65fbd3e
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Sep 13, 2023
d2728a4
chore: Button UX
EthanFreestone Sep 29, 2023
0bf7177
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Sep 29, 2023
2702209
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Oct 23, 2023
00644eb
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Dec 8, 2023
2f1cab6
refactor: Settings order
EthanFreestone Mar 1, 2024
a1320ae
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Mar 1, 2024
1eb29eb
chore: Linting and test fixes
EthanFreestone Mar 1, 2024
8381957
test: More tests and mocks to try and push PR through
EthanFreestone Mar 1, 2024
29c9b5c
Merge branch 'master' of github.com:folio-org/ui-inventory into feat/…
EthanFreestone Mar 7, 2024
ea9eccf
build: Change service interaction dependency to ^3.0.0
EthanFreestone Mar 28, 2024
b0a16b6
chore: Removed "Learn more" button
EthanFreestone Jun 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: Removed "Learn more" button
EthanFreestone committed Jun 18, 2024
commit b0a16b667e11780bd9dca40b4cdbc95338d493fb
10 changes: 0 additions & 10 deletions src/settings/NumberGeneratorOptions/NumberGeneratorOptionsForm.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, cover this component with unit tests

Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
Accordion,
AccordionSet,
AccordionStatus,
Button,

Check warning on line 10 in src/settings/NumberGeneratorOptions/NumberGeneratorOptionsForm.js

GitHub Actions / github-actions-ci

'Button' is defined but never used. Allowed unused vars must match /React/u
Checkbox,
Col,
ExpandAllButton,
@@ -234,16 +234,6 @@
}}
/>
</Layout>
<Layout className="display-flex flex-direction-column flex-align-items-center">
<Button
allowAnchorClick
buttonStyle="primary"
href="https://wiki.folio.org/display/FOLIOtips/Number+generator"
marginBottom0
>
<FormattedMessage id="ui-inventory.settings.learnMore" />
</Button>
</Layout>
</Layout>
}
iconSize="medium"

Unchanged files with check annotations Beta

setSegmentSortBy = (sortBy) => {
const { segment } = this.props;
const segmentsSortBy = this.state.segmentsSortBy.map((key) => {

Check failure on line 704 in src/components/InstancesList/InstancesList.js

GitHub Actions / github-actions-ci

Use callback in setState when referencing the previous state
if (key.name === segment) {
key.sort = sortBy;
return key;