UIIN-2986: Add showSortIndicator prop to SearchAndSort to display sort indicator next to the column names, and add correct nonInteractiveHeaders
#2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t indicator next to the column names, and add correct onInteractiveHeaders.
Dmytro-Melnyshyn
requested review from
BogdanDenis,
mariia-aloshyna,
OleksandrHladchenko1 and
a team
mariia-aloshyna
approved these changes
Aug 13, 2024
BogdanDenis
approved these changes
Aug 14, 2024
Dmytro-Melnyshyn
force-pushed
the
UIIN-2986
branch
from
2981794 to
2bf0f08
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Result list - add a sort indicator next to the column names for sortable fields and if the field is not currently sorted.
Approach
showSortIndicatorprop to theSearchAndSortcomponent;nonInteractiveHeaders.Removed unused fields, they are from the time when Search and Browse searches were on the same page.
Related PRs
folio-org/stripes-components#2333
folio-org/stripes-smart-components#1500
Refs
UIIN-2986
Screenshots
2024-08-13_16h50_28.mp4