Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN:3146: Update API URI for checkCanBeOpenedInLinkedData manifest #2678

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

pkjacob
Copy link
Contributor

@pkjacob pkjacob commented Nov 27, 2024

This PR addresses UIIN-3146

Purpose

The API URI GET /resource/check/{inventoryId}/supported has been changed to GET /linked-data/inventory-instance/{inventoryId}/import-supported in mod-linked-data as part of MODLD-585. This Pull request makes the corresponding change in ui-inventory codebase.

Approach

Update the API URI in ViewInstance.js

Refs

Related tickets:

  1. MODLD-585
  2. UILD-428

@pkjacob
Copy link
Contributor Author

pkjacob commented Nov 27, 2024

Hi @BogdanDenis, @mariia-aloshyna @KaterynaSenchenko
We need to include this change in Ramsons release also.

Copy link

github-actions bot commented Nov 27, 2024

Jest Unit Test Statistics

       1 files  ±0     253 suites  ±0   15m 4s ⏱️ -7s
1 014 tests ±0  1 012 ✔️ ±0  2 💤 ±0  0 ±0 
1 021 runs  ±0  1 019 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit e1b0138. ± Comparison against base commit 0359600.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@BogdanDenis BogdanDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to CHANGELOG

@@ -198,7 +198,7 @@ class ViewInstance extends React.Component {
},
checkCanBeOpenedInLinkedData: {
type: 'okapi',
path: 'resource/check/:{id}/supported',
path: 'linked-data/inventory-instance/:{id}/import-supported',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this enpoint require additional permissions?

Copy link
Contributor Author

@pkjacob pkjacob Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. No permissions changes are made for this API.

@pkjacob
Copy link
Contributor Author

pkjacob commented Nov 27, 2024

@BogdanDenis CHANGELOG added.

@pkjacob pkjacob requested a review from BogdanDenis November 27, 2024 16:22
@pkjacob pkjacob merged commit 1423654 into master Nov 28, 2024
5 checks passed
mariia-aloshyna pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants