Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-3188: ECS - Allow 'Move holdings/items to another instance' if instance is shared #2710

Merged
merged 2 commits into from
Jan 14, 2025
Merged

UIIN-3188: ECS - Allow 'Move holdings/items to another instance' if instance is shared #2710

merged 2 commits into from
Jan 14, 2025

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • Allow to display of ‘Move holdings/items to another instance' action on Instances that are ‘SHARED’.

Approach

  • Removed !isShared condition from canMoveHoldingsItemsToAnotherInstance

Refs

UIIN-3188

Screenshots

Before

image

After

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

Jest Unit Test Statistics

       1 files  ±0     255 suites  ±0   14m 45s ⏱️ +3s
1 023 tests ±0  1 021 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 030 runs  ±0  1 028 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit c572b9b. ± Comparison against base commit 2c41ae3.

♻️ This comment has been updated with latest results.

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team January 14, 2025 09:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit f648546 into master Jan 14, 2025
5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-3188 branch January 14, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@Dmytro-Melnyshyn Dmytro-Melnyshyn Awaiting requested review from Dmytro-Melnyshyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @BogdanDenis @mariia-aloshyna