UIIN-3207: Sort holdings by location name and call number #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instance view shows the holdings that belong to that instance. There are many libraries with many holdings per instance, they need this sorted by effectiveLocation.name, callNumberPrefix, callNumber, callNumberSuffix. Solution: Use this CQL query: `instanceId==5b966ed6-3cd6-4dda-a0c7-f9b5e2826ccd sortBy effectiveLocation.name callNumberPrefix callNumber callNumberSuffix`
OleksandrHladchenko1
approved these changes
Jan 28, 2025
BogdanDenis
approved these changes
Jan 28, 2025
|
zburke
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
- OMG I cannot believe results have been unsorted all these years! Thank you for noticing this and fixing it.
- Please review the ticket with Ryan Taylor, UIIN PO, before merging. Given the display is "effective location - prefix - cn - suffix" it's hard to imagine he'll ask for a different order but for user-facing changes like this we should still ask.
- But but but how does this work? Records returned by
/holdings-storage/holdingsdon't include a property namedeffectiveLocation.nameso how can you sort by it? 🪄 ✨ 🤨 and this property is not listed in API documentation. How could a developer who is not familiar with the undocumented internal implementation of mod-inventory-storage come up with this solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The instance view shows the holdings that belong to that instance. There are many libraries with many holdings per instance, they need this sorted by effectiveLocation.name, callNumberPrefix, callNumber, callNumberSuffix.
Approach
Use this CQL query:
instanceId==5b966ed6-3cd6-4dda-a0c7-f9b5e2826ccd sortBy effectiveLocation.name callNumberPrefix callNumber callNumberSuffixRefs
https://folio-org.atlassian.net/browse/UIIN-3207