UIIN-2557-settings-options-for-number-generators #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsenhans
requested review from
Dmytro-Melnyshyn,
mariia-aloshyna and
artem-blazhko
src/settings/NumberGeneratorSettings/NumberGeneratorSettingsForm.js
Outdated
Show resolved
Hide resolved
Dmytro-Melnyshyn
approved these changes
Feb 12, 2025
BogdanDenis
requested changes
Feb 13, 2025
| expect(screen.getByRole('button', { name: 'Collapse all' })).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('should disable useSharedNumber-checkbox and show warning if clicking callNumber or accessionNumber to use manually', async () => { |
There was a problem hiding this comment.
Please re-format the tests to follow this format:
describe('when condition', () => {
it('should do this', () => {});
});
There was a problem hiding this comment.
Also, this one tests contains too many expect statements, at this point it's not clear what is expected. Please split this test into several smaller ones with 1-2 clear expect statements at the end
There was a problem hiding this comment.
Thanks @BogdanDenis !
I re-formated and splitted the tests.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIIN-2557 Inventory Settings Options for using number generators for item barcode, accession number and call number
Purpose
Options for enabling / using the number generators for item barcode, call number and accession number needs to be available in Inventory Settings
Holdings level: call number
Item level: item barcode, accession number, call number
User story statement(s):
As a staff person I want to enable the number generators for item barcode, call number and / or accession number in Inventory App by selecting options in the Inventory Settings. In Settings under Inventory > Holdings, Items in the second/middle pane an entry “Number generator options” is displayed. Clicking on the “Number generator options” the third pane will be displayed with options:
(Default black banner for help text above options) Fields which are usually filled using a numeric sequence can use the number generator. When the generator is switched on the field can either be fixed to prevent manual update, or made fully editable. When switched off, the field must be filled manually.
Refs
https://folio-org.atlassian.net/browse/UIIN-2557
Screenshots