Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UINV-530 Include the currency in an invoice upon creation derived from a purchase order #756

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Feb 5, 2024

Purpose

https://folio-org.atlassian.net/browse/UINV-530

Approach

When creating an invoice from purchase orders, use the currency from the first associated PO line.

Screenshots

chrome_Z8nxUXpM0w.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Jest Unit Test Statistics

    1 files  ±0  113 suites  ±0   4m 49s ⏱️ +8s
350 tests ±0  350 ✔️ ±0  0 💤 ±0  0 ±0 
354 runs  ±0  354 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 9ff4ad2. ± Comparison against base commit cfffaa0.

Copy link

github-actions bot commented Feb 5, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 9ff4ad2. ± Comparison against base commit cfffaa0.

Copy link

sonarqubecloud bot commented Feb 5, 2024

@usavkov-epam usavkov-epam requested review from a team February 5, 2024 14:53
@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team February 5, 2024 15:03
@usavkov-epam usavkov-epam changed the base branch from master to develop February 6, 2024 14:35
@usavkov-epam usavkov-epam merged commit 32e895a into develop Feb 6, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UINV-530 branch February 6, 2024 14:35
NikitaSedyx pushed a commit that referenced this pull request Feb 21, 2024
NikitaSedyx pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants