Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIOR-1281 Applied 'Strategies' approach for error handling of order updates #1653

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Oct 3, 2024

Purpose

https://folio-org.atlassian.net/browse/UIOR-1281

Display FY code in the error with the code budgetNotFoundForFiscalYear.

Requires: folio-org/stripes-acq-components#817

Approach

Use the ResponseErrorsContainer builder to safe and useful get error details and handle them.
Apply the "Strategy" pattern for some errors for code splitting and decoupling the code.

Screenshots

chrome_uUmN5qWzcJ.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Jest Unit Test Statistics

    1 files  ±0  264 suites  ±0   6m 34s ⏱️ +3s
698 tests ±0  698 ✔️ ±0  0 💤 ±0  0 ±0 
706 runs  ±0  706 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 54e7953. ± Comparison against base commit 8fb386b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 3, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 54e7953. ± Comparison against base commit 8fb386b.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam requested review from a team October 3, 2024 13:41
@usavkov-epam
Copy link
Contributor Author

Tests will pass after merging of folio-org/stripes-acq-components#817

Copy link

sonarqubecloud bot commented Oct 7, 2024

@usavkov-epam usavkov-epam merged commit 83b2b98 into master Oct 7, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UIOR-1281 branch October 7, 2024 09:11
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usavkov-epam, whoops, this PR relies on ResponseErrorContainer folio-org/stripes-acq-components#817, a feature that won't be available until v5.2.0. So, actually, double whoops:

  1. stripes-acq-components did not correctly bump the version on master after its last release. That means new features (like ResponseErrorContainer) will appear to be available in the 5.1.x branch but in fact they will not be available until 5.2.x.
  2. Once (1) is fixed, you'll need to make a follow up here to bump the version to 5.2.0.

This works now in CI/folio-snapshot only because the version is wrong in (1) and wrong here, but as soon as you build a bundle from a production server where stripes-acq-components 5.1.x doesn't contain this feature, you'll get a build warning and this component will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants