-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIOR-1281 Applied 'Strategies' approach for error handling of order updates #1653
Conversation
Tests will pass after merging of folio-org/stripes-acq-components#817 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@usavkov-epam, whoops, this PR relies on ResponseErrorContainer folio-org/stripes-acq-components#817, a feature that won't be available until v5.2.0. So, actually, double whoops:
- stripes-acq-components did not correctly bump the version on master after its last release. That means new features (like ResponseErrorContainer) will appear to be available in the 5.1.x branch but in fact they will not be available until 5.2.x.
- Once (1) is fixed, you'll need to make a follow up here to bump the version to 5.2.0.
This works now in CI/folio-snapshot only because the version is wrong in (1) and wrong here, but as soon as you build a bundle from a production server where stripes-acq-components 5.1.x doesn't contain this feature, you'll get a build warning and this component will fail.
Purpose
https://folio-org.atlassian.net/browse/UIOR-1281
Display FY code in the error with the code
budgetNotFoundForFiscalYear
.Requires: folio-org/stripes-acq-components#817
Approach
Use the
ResponseErrorsContainer
builder to safe and useful get error details and handle them.Apply the "Strategy" pattern for some errors for code splitting and decoupling the code.
Screenshots
chrome_uUmN5qWzcJ.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.