UIORGS-388 Protection of viewing and changes of banking information b…

…y permissions
folio-org · Nov 21, 2023 · ed3070d · ed3070d
1 parent 914862d
commit ed3070d
Show file tree

Hide file tree

Showing 6 changed files with 62 additions and 17 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 * Implement organization's banking information form. Refs UIORGS-390.
 * Implement organization's banking information details view. Refs UIORGS-389.
 * Modify summary display in organization view mode. Refs UIORGS-398.
+* Protection of viewing and changes of banking information by permissions. Refs UIORGS-388.
 
 ## [5.0.0](https://github.com/folio-org/ui-organizations/tree/v5.0.0) (2023-10-12)
 [Full Changelog](https://github.com/folio-org/ui-organizations/compare/v4.0.0...v5.0.0)

diff --git a/package.json b/package.json
@@ -81,8 +81,6 @@
           "data-export.config.item.get",
           "orders.acquisition-methods.collection.get",
           "orders.acquisition-method.item.get",
-          "organizations.banking-information.collection.get",
-          "organizations.banking-information.item.get",
           "organizations.organizations.collection.get",
           "organizations.organizations.item.get",
           "organizations-storage.addresses.collection.get",
@@ -111,7 +109,6 @@
           "data-export.config.item.delete",
           "data-export.config.item.post",
           "data-export.config.item.put",
-          "organizations.banking-information.item.put",
           "organizations.organizations.item.put",
           "organizations-storage.addresses.item.put",
           "organizations-storage.emails.item.put",
@@ -131,7 +128,6 @@
         "displayName": "Organizations: View, edit, create",
         "visible": true,
         "subPermissions": [
-          "organizations.banking-information.item.post",
           "organizations.organizations.item.post",
           "organizations-storage.addresses.item.post",
           "organizations-storage.emails.item.post",
@@ -145,7 +141,6 @@
         "displayName": "Organizations: View, edit, delete",
         "visible": true,
         "subPermissions": [
-          "organizations.banking-information.item.delete",
           "organizations.organizations.item.delete",
           "organizations-storage.addresses.item.delete",
           "organizations-storage.emails.item.delete",
@@ -154,6 +149,42 @@
           "ui-organizations.edit"
         ]
       },
+      {
+        "permissionName": "ui-organizations.banking-information.view",
+        "displayName": "Organizations: View banking information",
+        "visible": true,
+        "subPermissions": [
+          "organizations.banking-information.collection.get",
+          "organizations.banking-information.item.get"
+        ]
+      },
+      {
+        "permissionName": "ui-organizations.banking-information.create",
+        "displayName": "Organizations: View and create banking information",
+        "visible": true,
+        "subPermissions": [
+          "ui-organizations.banking-information.view",
+          "organizations.banking-information.item.post"
+        ]
+      },
+      {
+        "permissionName": "ui-organizations.banking-information.edit",
+        "displayName": "Organizations: View, create and edit banking information",
+        "visible": true,
+        "subPermissions": [
+          "ui-organizations.banking-information.create",
+          "organizations.banking-information.item.put"
+        ]
+      },
+      {
+        "permissionName": "ui-organizations.banking-information.delete",
+        "displayName": "Organizations: View, create, edit and delete banking information",
+        "visible": true,
+        "subPermissions": [
+          "ui-organizations.banking-information.edit",
+          "organizations.banking-information.item.delete"
+        ]
+      },
       {
         "permissionName": "ui-organizations.creds.view",
         "displayName": "Organizations: Interface usernames and passwords: view",

diff --git a/src/Organizations/OrganizationDetails/OrganizationDetails.js b/src/Organizations/OrganizationDetails/OrganizationDetails.js
@@ -405,12 +405,14 @@ const OrganizationDetails = ({
                   </Accordion>
 
                   {isBankingInformationEnabled && (
-                    <Accordion
-                      id={ORGANIZATION_SECTIONS.bankingInformationSection}
-                      label={ORGANIZATION_SECTION_LABELS[ORGANIZATION_SECTIONS.bankingInformationSection]}
-                    >
-                      <OrganizationBankingInfo organization={organization} />
-                    </Accordion>
+                    <IfPermission perm="ui-organizations.banking-information.view">
+                      <Accordion
+                        id={ORGANIZATION_SECTIONS.bankingInformationSection}
+                        label={ORGANIZATION_SECTION_LABELS[ORGANIZATION_SECTIONS.bankingInformationSection]}
+                      >
+                        <OrganizationBankingInfo organization={organization} />
+                      </Accordion>
+                    </IfPermission>
                   )}
                 </>
               )

diff --git a/...Organizations/OrganizationForm/OrganizationBankingInfoForm/OrganizationBankingInfoForm.js b/...Organizations/OrganizationForm/OrganizationBankingInfoForm/OrganizationBankingInfoForm.js
@@ -3,6 +3,7 @@ import { FieldArray } from 'react-final-form-arrays';
 import { FormattedMessage } from 'react-intl';
 
 import { Loading } from '@folio/stripes/components';
+import { useStripes } from '@folio/stripes/core';
 
 import {
   useBankingAccountTypes,
@@ -27,6 +28,8 @@ const renderField = (props) => (name, index, fields) => (
 );
 
 export const OrganizationBankingInfoForm = () => {
+  const stripes = useStripes();
+
   const {
     bankingAccountTypes,
     isFetching: isBankingAccountTypesFetching,
@@ -54,6 +57,7 @@ export const OrganizationBankingInfoForm = () => {
     <FieldArray
       addLabel={<FormattedMessage id="ui-organizations.button.bankingInformation.add" />}
       component={BankingInformationFieldArray}
+      canRemove={stripes.hasPerm('ui-organizations.banking-information.delete')}
       id="bankingInformation"
       name={BANKING_INFORMATION_FIELD_NAME}
       onAdd={createAddNewItem()}

diff --git a/src/Organizations/OrganizationForm/OrganizationForm.js b/src/Organizations/OrganizationForm/OrganizationForm.js
@@ -3,6 +3,7 @@ import { FormattedMessage } from 'react-intl';
 import { useHistory } from 'react-router';
 import { mapValues } from 'lodash';
 
+import { IfPermission } from '@folio/stripes/core';
 import stripesForm from '@folio/stripes/final-form';
 import {
   Accordion,
@@ -223,12 +224,14 @@ const OrganizationForm = ({
                         </Accordion>
 
                         {isBankingInformationEnabled && (
-                          <Accordion
-                            id={ORGANIZATION_SECTIONS.bankingInformationSection}
-                            label={ORGANIZATION_SECTION_LABELS[ORGANIZATION_SECTIONS.bankingInformationSection]}
-                          >
-                            <OrganizationBankingInfoForm />
-                          </Accordion>
+                          <IfPermission perm="ui-organizations.banking-information.create">
+                            <Accordion
+                              id={ORGANIZATION_SECTIONS.bankingInformationSection}
+                              label={ORGANIZATION_SECTION_LABELS[ORGANIZATION_SECTIONS.bankingInformationSection]}
+                            >
+                              <OrganizationBankingInfoForm />
+                            </Accordion>
+                          </IfPermission>
                         )}
                       </>
                     )

diff --git a/translations/ui-organizations/en.json b/translations/ui-organizations/en.json
@@ -479,6 +479,10 @@
   "permission.creds.manage": "Organizations: Interface usernames and passwords: view, edit, create, delete",
   "permission.acqUnits.assign": "Organizations: Assign acquisition units to new organization",
   "permission.acqUnits.manage": "Organizations: Manage acquisition units",
+  "permission.banking-information.view": "Organizations: View banking information",
+  "permission.banking-information.create": "Organizations: View and create banking information",
+  "permission.banking-information.edit": "Organizations: View, create and edit banking information",
+  "permission.banking-information.delete": "Organizations: View, create, edit and delete banking information",
   "permission.settings.view": "Settings (Organizations): View settings",
   "permission.settings": "Settings (Organizations): Can view and edit settings"
 }