Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIPFIMP-65: Increase test coverage for FindImportProfile component #150

Merged
merged 4 commits into from
Jan 8, 2024
Merged

UIPFIMP-65: Increase test coverage for FindImportProfile component #150

merged 4 commits into from
Jan 8, 2024

Conversation

OleksandrHladchenko1
Copy link
Contributor

Links

UIPFIMP-65

Before

image

After

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Jest Unit Test Statistics

23 tests  +1   23 ✔️ +1   2m 6s ⏱️ -10s
  5 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c010fcb. ± Comparison against base commit 376d7f6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit c010fcb. ± Comparison against base commit 376d7f6.

♻️ This comment has been updated with latest results.

Terala-Priyanka
Terala-Priyanka suggested changes Jan 4, 2024
View reviewed changes
Copy link

@Terala-Priyanka Terala-Priyanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could import both the named imports on the same line? It fixes the lint errors.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OleksandrHladchenko1 OleksandrHladchenko1 changed the title UIDATIMP-65: Increase test coverage for FindImportProfile component UIPFIMP-65: Increase test coverage for FindImportProfile component Jan 5, 2024
@mariia-aloshyna
Copy link
Contributor

Jira ticket to clean up eslint errors - UIPFIMP-68

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team January 5, 2024 13:11
@OleksandrHladchenko1
Copy link
Contributor Author

Hi @Terala-Priyanka Please, review one more time

Terala-Priyanka
Terala-Priyanka approved these changes Jan 5, 2024
View reviewed changes
Copy link

@Terala-Priyanka Terala-Priyanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lint errors of same type in other files that you have not changed. Please correct them as well. It would hardly consume a minute of your time.

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit d37d8e6 into master Jan 8, 2024
6 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIPFIMP-65 branch January 8, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Terala-Priyanka Terala-Priyanka Terala-Priyanka approved these changes

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @mariia-aloshyna @Terala-Priyanka