UIQM-522 Create/Derive a new MARC bib record & Create a MARC holdings | Default state of Save & close button should be disabled. #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… | Default state of Save & close button should be disabled.
UladzislauKutarkin
approved these changes
Dec 5, 2023
vashjs
approved these changes
Dec 5, 2023
| const saveFormDisabled = action === QUICK_MARC_ACTIONS.EDIT | ||
| ? pristine || submitting | ||
| : submitting; | ||
| const saveFormDisabled = useMemo(() => { |
There was a problem hiding this comment.
I think useMemo is a little bit overhead here, because there are no huge re-calculations and it may cost more then improves. What about replace it with
const saveFormDisabled = submitting ? true : pristine;
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create/Derive a new MARC bib record & Create a MARC holdings | Default state of Save & close button should be disabled.
Screenshots
chrome_DELBoPhQJe.mp4
Issues
UIQM-522