Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-714: *BREAKING* Upgrade inventory to 14.0. #742

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Oct 8, 2024

Description

Upgrade inventory to 14.0 as the publicationPeriod field is removed in related PRs. It is not used in ui-quick-marc.

Related PRs

folio-org/mod-inventory#771
folio-org/mod-inventory-storage#1084

Issues

UIQM-714

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Oct 8, 2024

Jest Unit Test Statistics

    1 files  ±0    47 suites  ±0   3m 11s ⏱️ -1s
473 tests ±0  473 ✔️ ±0  0 💤 ±0  0 ±0 
476 runs  ±0  476 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 249bb96. ± Comparison against base commit 77ae919.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team October 8, 2024 07:21
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team October 8, 2024 07:44
Copy link

sonarqubecloud bot commented Oct 9, 2024

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 404af2f into master Oct 9, 2024
5 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIQM-714 branch October 9, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants