Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREQMED-85: Update upload-artifact actions from v3 to v4 #93

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

artem-blazhko
Copy link
Contributor

Purpose

Update upload-artifact actions from v3 to v4 to make builds successful.

Refs

UIREQMED-85

@artem-blazhko artem-blazhko requested a review from a team January 31, 2025 10:02
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, migrate to shared workflows by replacing build-npm* with ui.yml.

name: Centralized workflow
on: 
  - push
  - pull_request
  - workflow_dispatch

jobs:
  ui: 
    uses: folio-org/.github/.github/workflows/ui.yml@v1
    if: github.ref_name == github.event.repository.default_branch || github.event_name != 'push' || github.ref_type == 'tag'
    secrets: inherit
    with:
      jest-enabled: true
      jest-test-command: yarn run test:jest

Ping me when you are ready to migrate and I will make the small-but-required update in GitHub's repository settings.

@artem-blazhko artem-blazhko merged commit 1f61462 into master Jan 31, 2025
7 checks passed
@artem-blazhko artem-blazhko deleted the UIREQMED-85 branch January 31, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants