-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Given that this will be deployed to an environment with stripes v2.8.0 and that it is based of a release (v2.4) when that was the current stripes release, we will pin the dev-dep on stripes to v2.8 as well. The issue here is that subtle differences in the markup of some components, likely `<MultiColumnList>`, is causing unit test failures because we have v2.8-era selectors in the tests here in ui-users but NPM is pulling down a newer version to conduct the tests. At the API level, `<MCL>` _is still compatible_, but its internal markup, which these selectors inadvertently rely on, has changed.
- Loading branch information
Showing
3 changed files
with
19 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
const warn = console.warn; | ||
const blacklist = [ | ||
/componentWillReceiveProps has been renamed/, | ||
/componentWillUpdate has been renamed/, | ||
/componentWillMount has been renamed/, | ||
]; | ||
|
||
export default function turnOffWarnings() { | ||
console.warn = function (...args) { | ||
if (blacklist.some(rx => rx.test(args[0]))) { | ||
return; | ||
} | ||
warn.apply(console, args); | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters