Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-2993: Add the possibility to do "Claim returned" from action menu #2585

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

artem-blazhko
Copy link
Contributor

@artem-blazhko artem-blazhko commented Nov 9, 2023

Purpose

When user clicks on "Claim returned" button from the action menu dropdown item status becomes "Claimed returned" but fee/fine status is not "Suspended claim returned" and Fees/fines incurred is not "Suspended".

Approach

The issue happened because we did not have access to some data from manifest and as a result a few additional requests were not executed.
I extended already existing manifest to have all necessary "mutators" and "resources".

Refs

UIU-2993

@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team November 9, 2023 13:28
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@artem-blazhko artem-blazhko merged commit 8753d38 into master Nov 9, 2023
@artem-blazhko artem-blazhko deleted the UIU-2993 branch November 9, 2023 17:06
Terala-Priyanka added a commit that referenced this pull request Nov 10, 2023
* UIU-2977 x-okapi-token header must always be optional (#2578)

The `X-Okapi-Token` header is optional and should only be included when
a token value is present on the `stripes.okapi` object.

Refs UIU-2977

* UIU-2959 Accordion collapse/expand all shortcuts not working on Edit form. (#2566)

* use handlers frome stripes-components

* update yarn.lock

* log changes

* update yarn lock

* UIU-2973 - Update patron groups retrieval in user search to hold maxUnpagedResourceCount (#2583)

* UIU-2995 - Update resourceData and queryParams in UserSearchContainer.js to escape special characters in tags filter (#2584)

* UIU-2995 - Update resourceData and queryParams in UserSearchContainer.js to escape special characters in tags filter

* UIU-2995 - Upade changelog description

* UIU-2955 - add a header comment to escapeSpecialCharactersInTagFilters function

* Add the possibility to do "Claim returned" from action menu (#2585)

* Release v10.0.4

---------

Co-authored-by: Zak Burke <[email protected]>
Co-authored-by: John Coburn <[email protected]>
Co-authored-by: Artem Blazhko <[email protected]>
Terala-Priyanka added a commit that referenced this pull request Dec 5, 2023
…irtual item. (#2601)

* UIU-2967 Don't display affiliations of users with types `patron` or `dcb` (#2570)

* UIU-2967 Don't display affiliations of users with types 'patron' or 'dbc'

* PT comment

* add tests

* import order

* fix type naming

* UIU-2970 Make the `username` field required for users with the `staff` type in "ECS" mode (#2571)

* UIU-2970 Make the 'username' field required for users with the 'staff' type in ECS mode

* add unit tests

* Release v10.0.1 (#2574)

* Release v10.0.2 (#2577)

* Release v10.0.3

* Release v10.0.4 (#2586)

* UIU-2977 x-okapi-token header must always be optional (#2578)

The `X-Okapi-Token` header is optional and should only be included when
a token value is present on the `stripes.okapi` object.

Refs UIU-2977

* UIU-2959 Accordion collapse/expand all shortcuts not working on Edit form. (#2566)

* use handlers frome stripes-components

* update yarn.lock

* log changes

* update yarn lock

* UIU-2973 - Update patron groups retrieval in user search to hold maxUnpagedResourceCount (#2583)

* UIU-2995 - Update resourceData and queryParams in UserSearchContainer.js to escape special characters in tags filter (#2584)

* UIU-2995 - Update resourceData and queryParams in UserSearchContainer.js to escape special characters in tags filter

* UIU-2995 - Upade changelog description

* UIU-2955 - add a header comment to escapeSpecialCharactersInTagFilters function

* Add the possibility to do "Claim returned" from action menu (#2585)

* Release v10.0.4

---------

Co-authored-by: Zak Burke <[email protected]>
Co-authored-by: John Coburn <[email protected]>
Co-authored-by: Artem Blazhko <[email protected]>

* UIU-2964 - [DCB] Loan details: Disable loan actions (Lending library) (#2590)

* UIU-3000 Can not edit shadow user account (#2589)

* Release v10.0.5 (#2593)

* UIU-2987-poppy-dcb - Hide all actionalble buttons on user details pane (#2594)

* UIU-2987-poppy-dcb - Hide all actionalble buttons on user details pane

* UIU-2987-poppy-dcb - fix unit test failure

* UIU-2987-poppy-dcb - fix lint error

* UIU-2988-poppy-dcb - User - Open Loans: UI changes for supporting DCB circulation (#2598)

* UIU-2966-poppy-dcb - display item title and barcode as text for dcb virtual item.

---------

Co-authored-by: Yury Saukou <[email protected]>
Co-authored-by: Zak Burke <[email protected]>
Co-authored-by: John Coburn <[email protected]>
Co-authored-by: Artem Blazhko <[email protected]>
Co-authored-by: Mikita Siadykh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants