UIU-3000 Can not edit shadow user account #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaSedyx
requested review from
usavkov-epam,
Terala-Priyanka and
alisher-epam
usavkov-epam
approved these changes
Nov 17, 2023
alisher-epam
approved these changes
Nov 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
usavkov-epam
pushed a commit
that referenced
this pull request
Nov 21, 2023
usavkov-epam
pushed a commit
that referenced
this pull request
Nov 21, 2023
Terala-Priyanka
added a commit
that referenced
this pull request
Dec 5, 2023
…irtual item. (#2601) * UIU-2967 Don't display affiliations of users with types `patron` or `dcb` (#2570) * UIU-2967 Don't display affiliations of users with types 'patron' or 'dbc' * PT comment * add tests * import order * fix type naming * UIU-2970 Make the `username` field required for users with the `staff` type in "ECS" mode (#2571) * UIU-2970 Make the 'username' field required for users with the 'staff' type in ECS mode * add unit tests * Release v10.0.1 (#2574) * Release v10.0.2 (#2577) * Release v10.0.3 * Release v10.0.4 (#2586) * UIU-2977 x-okapi-token header must always be optional (#2578) The `X-Okapi-Token` header is optional and should only be included when a token value is present on the `stripes.okapi` object. Refs UIU-2977 * UIU-2959 Accordion collapse/expand all shortcuts not working on Edit form. (#2566) * use handlers frome stripes-components * update yarn.lock * log changes * update yarn lock * UIU-2973 - Update patron groups retrieval in user search to hold maxUnpagedResourceCount (#2583) * UIU-2995 - Update resourceData and queryParams in UserSearchContainer.js to escape special characters in tags filter (#2584) * UIU-2995 - Update resourceData and queryParams in UserSearchContainer.js to escape special characters in tags filter * UIU-2995 - Upade changelog description * UIU-2955 - add a header comment to escapeSpecialCharactersInTagFilters function * Add the possibility to do "Claim returned" from action menu (#2585) * Release v10.0.4 --------- Co-authored-by: Zak Burke <[email protected]> Co-authored-by: John Coburn <[email protected]> Co-authored-by: Artem Blazhko <[email protected]> * UIU-2964 - [DCB] Loan details: Disable loan actions (Lending library) (#2590) * UIU-3000 Can not edit shadow user account (#2589) * Release v10.0.5 (#2593) * UIU-2987-poppy-dcb - Hide all actionalble buttons on user details pane (#2594) * UIU-2987-poppy-dcb - Hide all actionalble buttons on user details pane * UIU-2987-poppy-dcb - fix unit test failure * UIU-2987-poppy-dcb - fix lint error * UIU-2988-poppy-dcb - User - Open Loans: UI changes for supporting DCB circulation (#2598) * UIU-2966-poppy-dcb - display item title and barcode as text for dcb virtual item. --------- Co-authored-by: Yury Saukou <[email protected]> Co-authored-by: Zak Burke <[email protected]> Co-authored-by: John Coburn <[email protected]> Co-authored-by: Artem Blazhko <[email protected]> Co-authored-by: Mikita Siadykh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/UIU-3000
Approach
fix validation for shadow users to not check disabled fields
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.