-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIU-2988 - User - Open Loans: UI changes for supporting DCB circulation #2591
Conversation
… action menu items for DCB Lending library
Kudos, SonarCloud Quality Gate passed! |
@@ -3,6 +3,7 @@ | |||
|
|||
|
|||
"@aashutoshrathi/word-wrap@^1.2.3", "@aashutoshrathi/word-wrap@^1.2.6", "word-wrap@npm:@aashutoshrathi/word-wrap@^1.2.6": | |||
name word-wrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, without which lint script is not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should have been named isDcbItem
to be consistent with the existing isDcbUser
. I realize it seems petty, but inconsistencies like this add tiny amounts of friction that gradually overwhelm. Can you fix this?
@zburke https://issues.folio.org/browse/UIU-3020 has been created. |
Disable open loan action buttons and hide open loan record action menu items for DCB Lending library
Purpose
UIU-2988 - https://issues.folio.org/browse/UIU-2988
Approach
Virtual user and virtual items are considered to determine DCB library roles.
Virtual User or DCB user will have lastName hardcoded to "DcbSystem" and type would be 'dcb'
Virtual Item would have hard coded instance id and holdings record id
Screencast
borrowing-pickup - open loans page
lending role - open loans page
pickup role - open loans page
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.