Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-2988 - User - Open Loans: UI changes for supporting DCB circulation #2591

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

Terala-Priyanka
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka commented Nov 20, 2023

Disable open loan action buttons and hide open loan record action menu items for DCB Lending library

Purpose

UIU-2988 - https://issues.folio.org/browse/UIU-2988

Approach

Virtual user and virtual items are considered to determine DCB library roles.
Virtual User or DCB user will have lastName hardcoded to "DcbSystem" and type would be 'dcb'
Virtual Item would have hard coded instance id and holdings record id

Screencast

borrowing-pickup - open loans page
borrowing-pickup-role-open-loans

lending role - open loans page
lending-role-open-loans

pickup role - open loans page
pick-role-open-loans

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@Terala-Priyanka Terala-Priyanka marked this pull request as draft November 20, 2023 10:08
@Terala-Priyanka Terala-Priyanka self-assigned this Nov 20, 2023
@Terala-Priyanka Terala-Priyanka changed the title UIU-2988 - Disable open loan action buttons and hide open loan record… UIU-2988 - User - Open Loans: UI changes for supporting DCB circulation Nov 27, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.5% 96.5% Coverage
0.0% 0.0% Duplication

@Terala-Priyanka Terala-Priyanka marked this pull request as ready for review November 27, 2023 11:01
@Terala-Priyanka Terala-Priyanka requested a review from a team November 27, 2023 11:03
@@ -3,6 +3,7 @@


"@aashutoshrathi/word-wrap@^1.2.3", "@aashutoshrathi/word-wrap@^1.2.6", "word-wrap@npm:@aashutoshrathi/word-wrap@^1.2.6":
name word-wrap

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, without which lint script is not working

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team November 27, 2023 11:51
@Terala-Priyanka Terala-Priyanka requested a review from a team November 27, 2023 12:49
@Terala-Priyanka Terala-Priyanka merged commit 6c878e6 into master Nov 29, 2023
4 checks passed
@Terala-Priyanka Terala-Priyanka deleted the UIU-2988 branch November 29, 2023 11:09
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should have been named isDcbItem to be consistent with the existing isDcbUser. I realize it seems petty, but inconsistencies like this add tiny amounts of friction that gradually overwhelm. Can you fix this?

@Terala-Priyanka
Copy link
Contributor Author

This function should have been named isDcbItem to be consistent with the existing isDcbUser. I realize it seems petty, but inconsistencies like this add tiny amounts of friction that gradually overwhelm. Can you fix this?

@zburke https://issues.folio.org/browse/UIU-3020 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants