Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-3013 - Refactor feefines css away from color() function #2603

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Dec 7, 2023

https://issues.folio.org/browse/UIU-3013

Minor CSS refactor as we strive to eliminate a non-spec postcss- dependency. This doesn't change appearance, just implementation. The spec for color() has changed - and native color() does not function in the same way that we use it in a number of places - in this case, to obtain a contrasted version and then blend it with the original...

oklch colorspace is a new color space that assures better, more accessible outcomes to color adjustment.
CSS color-adjustment syntax (from ...) is a new feature that allows for adjustment of pre-existing colors.
color-mix() is a native function that can be used to blend colors.

@JohnC-80 JohnC-80 requested review from Terala-Priyanka and a team December 7, 2023 14:43
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JohnC-80 JohnC-80 merged commit 422eb8c into master Dec 8, 2023
4 checks passed
@JohnC-80 JohnC-80 deleted the UIU-3013 branch December 11, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants