Fix precision rounding issues in LineWrapper #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle JS quirks with large decimal precision checks resulting from the calculations of next lines in the LineWrapper
hollandjake
force-pushed
the
line-wrapper-rounding-issues
branch
from
3fd0f80 to
1e121dd
Compare
hollandjake
changed the title
|
LGTM |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Handle JS quirks with large decimal precision checks resulting from the calculations of next lines in the LineWrapper
Checklist:
Yes this is a very niche situation but it has caused many headaches for me when working with very precise measurements and/or weird font sizes