Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table support #394

Closed
wants to merge 2 commits into from
Closed

Table support #394

wants to merge 2 commits into from

Conversation

sanderboom
Copy link

Table support (#29) that @giuseppe-santoro made available, with small adjustments to make it run with PDFKIT:master (for my use at least)

All credits belong to @giuseppe-santoro

@sanderboom sanderboom changed the title Table support that Table support May 15, 2015
@bizarrochris
Copy link

👍

@jwerre
Copy link

jwerre commented Sep 4, 2015

What is the ETA on this? Is it ready to be merged into master?

@leobudima
Copy link

👍 :)

@zopieux
Copy link

zopieux commented Nov 19, 2015

@giuseppe-santoro, @sanderboom, do you know what is the status of this PR (and the very wanted table support, by extension)? Any plan to merge, add tests?

@sanderboom
Copy link
Author

@zopieux I think @devongovett should answer this ;) Personally, I don't use pdfkit anymore

@giuseppe-santoro
Copy link

Me too

@ghost
Copy link

ghost commented Dec 24, 2015

@sanderboom what are you using instead?

@sanderboom
Copy link
Author

@johannds Actually I've no need now for this functionality right now

@dylansmith
Copy link

+1, could really use this in master quite urgently. Happy to do conflict resolution as long as the maintainers are willing to merge it.

@lifeisfoo
Copy link

👍

1 similar comment
@deenairn
Copy link

👍

@simonbengtsson
Copy link

@johannds I would recommend pdfmake for creating pdf tables or jspdf with my autotable plugin. I would love to see this merged however!

@anotheri
Copy link

👍 👍

@acis
Copy link

acis commented Feb 24, 2016

👍

1 similar comment
@peterschmidler
Copy link

👍

@WilcoBakker
Copy link

Is this ever going to be merged?

@devongovett
Copy link
Member

This pull doesn't look like it was ever finished (lots of TODO messages in the code). Also, I think this can be done by a higher level library. Have a look at pdfmake which offers a nice declarative API on top of PDFKit, and supports tables excellently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.