-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table support #394
Table support #394
Conversation
👍 |
What is the ETA on this? Is it ready to be merged into master? |
👍 :) |
@giuseppe-santoro, @sanderboom, do you know what is the status of this PR (and the very wanted table support, by extension)? Any plan to merge, add tests? |
@zopieux I think @devongovett should answer this ;) Personally, I don't use pdfkit anymore |
Me too |
@sanderboom what are you using instead? |
@johannds Actually I've no need now for this functionality right now |
+1, could really use this in master quite urgently. Happy to do conflict resolution as long as the maintainers are willing to merge it. |
👍 |
1 similar comment
👍 |
👍 👍 |
👍 |
1 similar comment
👍 |
Is this ever going to be merged? |
This pull doesn't look like it was ever finished (lots of TODO messages in the code). Also, I think this can be done by a higher level library. Have a look at pdfmake which offers a nice declarative API on top of PDFKit, and supports tables excellently. |
Table support (#29) that @giuseppe-santoro made available, with small adjustments to make it run with PDFKIT:master (for my use at least)
All credits belong to @giuseppe-santoro