Skip to content

Commit

Permalink
fix(dropdown): set placeholdertext regardless of values
Browse files Browse the repository at this point in the history
In situations where values are given for a dropdown, but the list is empty (or no value is selected), and also allowAdditions:true is set, a given placeholder wont be shown. That's because internally the dropdownlist does not get cleared when allowAdditions is true which also does not (re-)set the placeholder.

By always trying to show a placeholder this situation gets fixed.
  • Loading branch information
lubber-de authored Nov 28, 2024
1 parent 66f0d1e commit 1d9a088
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/definitions/modules/dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@
module.set.initialLoad();
module.change.values(settings.values);
module.remove.initialLoad();
} else if (module.get.placeholderText() !== '') {
}
if (module.get.placeholderText() !== '') {
module.set.placeholderText();
}

Expand Down

0 comments on commit 1d9a088

Please sign in to comment.