Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calendar] Add timegap setting to expand time selector #198

Merged
merged 3 commits into from
Oct 24, 2018
Merged

[Calendar] Add timegap setting to expand time selector #198

merged 3 commits into from
Oct 24, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Oct 24, 2018

First, i'm not the work's author, all kudos belong to @soar_lin (PR here). I just add some fixes for better reliability.

This PR allow different time gaps to be set, allowing different time selections (5 which is default, 10, 15, 20 and 30).

Screenshot (when possible)

10 minutes gap:
7323763bf6acf1ea684cf4f07ae5f886.png

15 minutes gap:
56e492853d2cf6d65beee7533031df70.png

@prudho prudho added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Oct 24, 2018
@prudho prudho added this to the 2.7.x milestone Oct 24, 2018
@prudho prudho self-assigned this Oct 24, 2018
lubber-de
lubber-de approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 2f05013 into fomantic:beta Oct 24, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 24, 2018
@y0hami y0hami mentioned this pull request Oct 24, 2018
Merged
@y0hami
Copy link
Member

y0hami commented Oct 24, 2018

Planned for 2.7

@prudho prudho deleted the calendar-timegap branch November 13, 2018 15:56
@prudho prudho restored the calendar-timegap branch December 3, 2018 16:14
This was referenced Dec 21, 2018
Merged
Merged
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.0 Jan 5, 2019
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Jan 5, 2019
@lubber-de lubber-de mentioned this pull request Jan 22, 2019
Open
@lubber-de
Copy link
Member

Fixes mdehoog/Semantic-UI-Calendar#117

@prudho prudho deleted the calendar-timegap branch April 11, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami Awaiting requested review from y0hami

Assignees

@prudho prudho

Labels
lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@prudho @y0hami @lubber-de @ColinFrick