Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce CSS by removing :not() selectors if variation is disabled #3118

Open
wants to merge 43 commits into
base: develop
Choose a base branch
from
Open

Reduce CSS by removing :not() selectors if variation is disabled #3118

wants to merge 43 commits into from

Conversation

lubber-de
Copy link
Member

Description

A lot of :not() css selectors are not needed when the related variation has been disabled and thus isn't compiled
This PR makes sure such selectors are removed upon compilation which reduces the generated css even more

For example if one disables circular step in variation.variables (or in a custom site.variables)

@variationStepCircular: false;

then all the :not(.circular) selectors can be removed as a .ui.circular.step won't exist after compilation, so there is no need to differentiate between them anymore

As everything is enabled by default, this change does not affect anything and is completely backward compatible

@lubber-de
feat(step): reduce css if variations are disabled
ce82c4d
@lubber-de
feat(step): reduce css if variations are disabled
ec65596
@lubber-de
feat(form): reduce css if variations are disabled
3b871b6
@lubber-de
feat(grid): reduce css if variations are disabled
8a74fc8
@lubber-de
feat(menu): reduce css if variations are disabled
01b693a
@lubber-de
feat(table): reduce css if variations are disabled
38eea6b
@lubber-de
feat(button): reduce css if variations are disabled
f9049b3
@lubber-de
feat(container): reduce css if variations are disabled
a7c4fe8
@lubber-de
feat(divider): reduce css if variations are disabled
f99e7ba
@lubber-de
feat(emoji): reduce css if variations are disabled
1e42821
@lubber-de
feat(header): reduce css if variations are disabled
751363e
@lubber-de
feat(icon): reduce css if variations are disabled
e2a82a1
@lubber-de
feat(input): reduce css if variations are disabled
56b9dcb
@lubber-de
feat(label): reduce css if variations are disabled
0ea4225
@lubber-de
feat(list): reduce css if variations are disabled
79fce53
@lubber-de
feat(loader): reduce css if variations are disabled
2f5d84d
@lubber-de
feat(input): reduce css if variations are disabled
e71f29c
@lubber-de
feat(segment): reduce css if variations are disabled
639cc5a
@lubber-de
feat(card): reduce css if variations are disabled
9318ec6
@lubber-de
feat(feed): reduce css if variations are disabled
03feab3
@lubber-de
feat(item): reduce css if variations are disabled
363479c
@lubber-de
feat(accordion): reduce css if variations are disabled
0ca40d3
@lubber-de
feat(calendar): reduce css if variations are disabled
1f9685f
@lubber-de
feat(checkbox): reduce css if variations are disabled
835257b
@lubber-de
feat(dimmer): reduce css if variations are disabled
e6024bd
@lubber-de
feat(checkbox): reduce css if variations are disabled
cd99c57
@lubber-de
feat(dimmer): reduce css if variations are disabled
afa64fb
@lubber-de
feat(dropdown): reduce css if variations are disabled
2c00fae
@lubber-de
feat(flyout): reduce css if variations are disabled
c85b106
@lubber-de
feat(modal): reduce css if variations are disabled
fd984c0
@lubber-de lubber-de added lang/css Anything involving CSS type/build Anything related to the build process state/awaiting-reviews Pull requests which are waiting for reviews labels Nov 10, 2024
@lubber-de lubber-de added this to the 2.9.4 milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ko2in ko2in Awaiting requested review from ko2in

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@prudho prudho Awaiting requested review from prudho

@y0hami y0hami Awaiting requested review from y0hami

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews type/build Anything related to the build process
Projects
None yet
Milestone
2.9.4
Development

Successfully merging this pull request may close these issues.
1 participant
@lubber-de