Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): support blur for dropdowns #3129

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

lubber-de
Copy link
Member

Description

non search dropdowns only have a hidden input. Hidden inputs dont support the blur event.
This PR supports that in the way that the change event will also check if it was triggered on a hidden input but on: 'blur' was configured, as the change event will also be applied for hidden inputs

Testcase

https://jsfiddle.net/lubber/tmhrgz41/1/

Closes

#2797

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-reviews Pull requests which are waiting for reviews javascript Pull requests that update Javascript code labels Nov 24, 2024
@lubber-de lubber-de added this to the 2.9.4 milestone Nov 24, 2024
@mvorisek
Copy link
Contributor

The jsfiddle - https://jsfiddle.net/lubber/tmhrgz41/1/ - does not work on my side.

Steps to reproduce:

  1. click save
  2. errors are set for both fields - expected
  3. click input field
  4. click somewhere else - error on input field is gone - expected
  5. click dropdown field
  6. click somewhere else - error on dropdown field is kept - I would expect it gone as well, hence this issue

@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 3, 2024
@lubber-de lubber-de marked this pull request as draft December 3, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants