-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernized svg-font-dump #5
Open
renarsvilnis
wants to merge
13
commits into
fontello:master
Choose a base branch
from
renarsvilnis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump 🔨 |
Ping |
Sorry, this project is critical for old-fashioned fontello fonts repos, and need to be in frozen state. Until someone find time (never) to fix all that chaos. Please, do a fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
came accross your module today, it did what I needed it to do. Thanks for it!
But there was a
DeprecationWarning: Calling an asynchronous function without callback is deprecated.
due to the module not being updated last couple of years. After inspecting source, I found out thatfs.writeFile
without a callback. I forked & cloned the repo and fixed the issue and also did a refactor of the entire module and here is a list of what I did:semistandard
configfs
operations in async which resulted glyph write operations to run concurrently. Thus performance gains (not really needed, but still)require('svg-font-dump')
._
) symbols to dash (-
) symbolssome_argument
=>some-argument
make it more consistent as other cli applications Only breaking change for existing usersmake
file to reflect linter changeSuggest bumping the module to
v2.0.0
.Hope the changes are welcomed! 👍