Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(font): add pretendard #84

Merged
merged 1 commit into from
Sep 11, 2024
Merged

feat(font): add pretendard #84

merged 1 commit into from
Sep 11, 2024

Conversation

myodan
Copy link
Contributor

@myodan myodan commented Aug 26, 2024

Pretendardfonts also support dynamic subsets and variable dynamic subsets, but I'm not sure how to add them to the font source. There is a guide for regular fonts, but no guide for how to add other subsets.

Or can someone explain it to me...

Copy link
Member

@ayuhito ayuhito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for contributing!

but no guide for how to add other subsets.

Unfortunately, Fontsource doesn't support that unless it's directly imported from Google Fonts.

@ayuhito ayuhito merged commit bbfe02d into fontsource:main Sep 11, 2024
1 check passed
@ayuhito ayuhito mentioned this pull request Sep 11, 2024
@myodan myodan deleted the pretendard branch September 13, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants