Make the ingressClassName optional

[imgios]

Description

I think that by default the ingress class name should be empty, because nginx is not the only one, and could be that the user is using something else (e.g. Traefik).

Solution you'd like

servarr/values.yaml

Line 417 in 8a0aa86

ingressClassName: nginx

Comment out each IngressClassName parameter from the values.yaml

Code of Conduct

• I agree to follow this project's Code of Conduct

[fonzdm]

Yeah, that's true! Another thing that went under the hoods...
Do you suggest removing it completely or following the same principle as storageClass (using a global value, with an anchor?)

[imgios]

I think we can comment it out, in this way end users will know how to set it up correctly if they want to use a different ingress class, otherwise the deployment will use the default ingress class.

Otherwise, we can also make use of a global parameter and then use another pointer in the values to reference it. But is it good to use the YAML pointers? Is there an explanation on why no one use them in the Charts values?

[imgios]

I haven't found anything about the pros and cons of using anchors within Helm Chart values, but I'll start working on it. If we decide to get rid of anchors, we may be able to adapt it in later stages.

[fonzdm]

Closed with #31