Add global.ingressClassName anchor without default value

[imgios]

• Please check if the PR fulfills these requirements

• The branch naming convention follows our guidelines
• Docs have been added / updated (for bug fixes / features)

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

There's a new global.ingressClassName parameter that can be used to change the Ingress Class.

• What is the current behavior? (You can also link to an open issue here)

The Ingress Class is set all around the values with the default value nginx.

• What is the new behavior (if this is a feature change)?

New global parameter global.ingressClassName that makes use of YAML anchors to spread it all around the Chart.

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

• Other information:

None

[fonzdm]

Hi @imgios, thanks for your work!
I was testing out your branch and I found out:

• when a proper string is defined for the ingressClassName, all ingress resources are created correctly
• when we leave this parameter empty, we get this (for example, in the sonarr section where the anchor is referenced):

sonarr:
  ingress:
    sonarr-ing:
      annotations:
        cert-manager.io/cluster-issuer: letsencrypt-cloudflare
      enabled: true
      expandObjectName: false
      hosts:
      - host: <REDACTED>
        paths:
        - path: /
          pathType: Prefix
      ingressClassName: null

This will cause the ingress objects to be created like this:

kubectl get ing -n servarr
NAME              CLASS    HOSTS         ADDRESS   PORTS     AGE
radarr-ing        <none>   <REDACTED>              80, 443   4s
jellyfin-ing      <none>   <REDACTED>              80, 443   4s
sonarr-ing        <none>   <REDACTED>              80, 443   4s
prowlarr-ing      <none>   <REDACTED>              80, 443   4s
jellyseerr-ing    <none>   <REDACTED>              80, 443   4s
qbittorrent-ing   <none>   <REDACTED>              80, 443   4s

• same occurs if we use an empty string (like "")

I don't know of any other option.. if we put "-", we get an error about yaml syntax (probably because the dash sign is interpreted as the beginning of a list).

Probably we just need to force the users to write something here 😅

[imgios]

Probably we just need to force the users to write something here 😅

Thanks for testing this out. I would more like to leave the anchors out instead of forcing the user to write something. What do you think?

This means that we also have to review the storageClass next.

[imgios]

Let's do one thing. For the moment, I will use nginx as default value, in this way we have one piece already in place (the anchors that let us change the ingressClass everywhere). The best would be having the dependencies able to read parameters from the global section, I will try to discuss with them 😊

[fonzdm]

LGTM