Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage class name variable #18

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix storage class name variable #18

merged 1 commit into from
Apr 18, 2024

Conversation

mrgionsi
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • The branch naming convention follows our guidelines
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fixing

  • What is the current behavior? (You can also link to an open issue here)

StorageClass name is not generated correctly due to wrong storageClassName value.

  • What is the new behavior (if this is a feature change)?

The Helm Chart generate PVC templates using the correct StorageClassName from the values.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

@mrgionsi mrgionsi added the bug Something isn't working label Apr 18, 2024
@imgios imgios self-requested a review April 18, 2024 13:33
Copy link
Collaborator

@imgios imgios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Just checked also the pipeline build and it seems to be doing it right:

# Source: servarr/templates/pvc.yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: downloads-volume
  annotations:
    ...
spec:
  storageClassName: longhorn
...
---
# Source: servarr/templates/pvc.yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: media-volume
  annotations:
    ...
spec:
  storageClassName: longhorn
...
    requests:
      storage: 250Gi
---
# Source: servarr/templates/pvc.yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: torrent-config
  annotations:
    ...
spec:
  storageClassName: longhorn
...

This can be merged 👏🏻

@imgios imgios merged commit 6347ba8 into dev Apr 18, 2024
3 checks passed
@imgios imgios deleted the fix/storage-class-value branch April 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants