Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prowlarr api for qbittorrent registration #23

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

fonzdm
Copy link
Owner

@fonzdm fonzdm commented Apr 23, 2024

  • Please check if the PR fulfills these requirements
  • The branch naming convention follows our guidelines
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

With this PR, qBitTorrent gets correctly registered inside Prowlarr on helm chart deploy.

  • What is the current behavior? (You can also link to an open issue here)

At the moment, qBitTorrent is not registered in Prowlarr. The failure in the API did not make the helm install fail.
This does not affect Jellyfin or Jellyseerr (since they rely upon sonarr and radarr).

  • What is the new behavior (if this is a feature change)?

Now Prowlarr can be used to directly download stuff found via the configured indexers.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Yes, in the sense that it resolves a bug that made a prwolarr feature not working.

  • Other information:

While fixing this but, an API invocation has been removed (Path mapping between Prowlarr and qBitTorrent) since this configuration is not supported (it was merely migrated from Sonarr/Radarr but has never been tested).

closes #22

@fonzdm fonzdm added the bug Something isn't working label Apr 23, 2024
@fonzdm fonzdm requested a review from imgios April 23, 2024 13:54
@fonzdm fonzdm self-assigned this Apr 23, 2024
@fonzdm fonzdm linked an issue Apr 23, 2024 that may be closed by this pull request
1 task
Copy link
Collaborator

@imgios imgios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@imgios imgios merged commit 4baf014 into dev Apr 23, 2024
3 checks passed
@imgios imgios deleted the fix/prowlarr-vs-torrent-api branch April 23, 2024 14:05
@fonzdm fonzdm mentioned this pull request Apr 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding qBitTorrent as download client for Prowlarr failing
2 participants