Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce workflow to use this repo as Helm repo #26

Closed
wants to merge 9 commits into from

Conversation

lucaam
Copy link
Collaborator

@lucaam lucaam commented Apr 24, 2024

  • Please check if the PR fulfills these requirements
  • The branch naming convention follows our guidelines
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
  • Other information:

Issue: #8

@lucaam lucaam added the ci Changes related to CI label Apr 24, 2024
@lucaam lucaam self-assigned this Apr 24, 2024
@imgios imgios requested a review from fonzdm April 24, 2024 21:04
@fonzdm fonzdm requested review from imgios and removed request for fonzdm May 7, 2024 09:46
@fonzdm
Copy link
Owner

fonzdm commented May 7, 2024

@imgios I will let you handle this, I am busy right now with other stuff.

Copy link
Collaborator

@imgios imgios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucaam,
Thank you for the effort and the following PR.

I'm sorry, but I have to request some changes based on the answer provided by @fonzdm in the issue.

Please, since @fonzdm prefers to (1) keep the current repo structure and (2) use ArtifactHub, can you:

  • Revert the repository structure to the one currently in use in the dev branch
  • Focus on a separate pipeline that will take the Helm Chart tar and push it towards the ArtifactHub

Will be waiting for you changes. Have fun! 🚀

@imgios
Copy link
Collaborator

imgios commented May 7, 2024

And please, can you fill the PR template fields? I see you are still missing the following ones:

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Thank you! 😊

@fonzdm
Copy link
Owner

fonzdm commented May 9, 2024

@lucaam we will take this from now on, we discovered that artifacthub.io is just an index for helm charts and we need to deploy directly using github pages and, if possible, ghrc oci repo.
😄

@fonzdm fonzdm closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants