Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use h4 instead of unordered list #45

Merged
merged 2 commits into from
May 14, 2024
Merged

use h4 instead of unordered list #45

merged 2 commits into from
May 14, 2024

Conversation

imgios
Copy link
Collaborator

@imgios imgios commented May 14, 2024

Please check if the PR fulfills these requirements

  • The branch naming convention follows our guidelines
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Enhancement

What is the current behavior? (You can also link to an open issue here)

The pull request template currently used relies on unordered list items for each section, and this makes writing a PR a bit messy when using lists in those sections.

What is the new behavior (if this is a feature change)?

Unordered list items are being replaced with H4, an example is the following PR written using the new template.

The following list is an example:

  • item 1
  • item 2
    1. subitem
    2. subitem
    3. subitem
  • item 3

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

None

Other information:

None

@imgios imgios added the enhancement New feature or request label May 14, 2024
@imgios imgios requested a review from fonzdm May 14, 2024 16:46
@imgios imgios self-assigned this May 14, 2024
@imgios imgios marked this pull request as draft May 14, 2024 16:47
@imgios imgios marked this pull request as ready for review May 14, 2024 16:48
Copy link
Owner

@fonzdm fonzdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@fonzdm
Copy link
Owner

fonzdm commented May 14, 2024

Please remember to align the dev branch

@fonzdm fonzdm merged commit 1e09f16 into main May 14, 2024
3 checks passed
@fonzdm fonzdm deleted the feat/pr-template branch May 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants