-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP (PLEASE DON'T MERGE): 64-bit version #28
base: main
Are you sure you want to change the base?
Conversation
i think this pull request is too large - 143 files changes in whole - who should review that?
björk also "ported" the 1.1.2 Version, you join forces? https://github.com/bjrkk/3DMM-BRender (builds with VS2022,clang and mingw gcc, 32 and 64bit)
is this stub optional? can one switch between the 32bit libs and your stub?
the IN_80386 activates most of the x86 inline asm - 3DMM doesn't build even in 32bit full without that |
Wouldn't BRender require updating to support 64bit, or is that covered in this PR? Maybe break it out into
|
I would like to add to the recommendation that this PR be split up. I'd also like to advocate that vendoring a BRender implementation is not really a solution here. It precludes the ability for us to easily track upstream BRender implementations, doesn't allow for things like FetchContent, and as others have said, the null stub for audioman also makes it difficult to switch between versions. My recommendations for getting this PR into a final state to merge are
Work regarding a 64-bit replacement/stub for AudioMan can be done separately and alongside all of this, I should note (though given bjrkk's work on getting the SDL renderer to work, I expect SDL audio will be used at some point) |
Thanks for the feedback. This branch is a work in progress, please don't try to merge it yet. I'll look into splitting this work up. |
Is there a real need for generating c/cpp code?, isnt that some sort of loop unrolling, thats also not needed anymore |
I fixed some loading issues. You can now enter the editor and place actors. |
Here is a work-in-progress branch to port 3D Movie Maker to 64-bit Windows!
This will not only bring 3D Movie Maker into the 64-bit future, but another perk is that rewriting the x86-specific parts of the code will make it easier to port 3DMM to other platforms.
Currently, the project builds and runs most of the menu. It crashes when you attempt to create or play a movie. "Internal error 103" messages may appear, but the program will continue.
Since the original code depends on 32-bit libraries, I tried to patch up the missing pieces: