Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cristi/md extraction #5961

Draft
wants to merge 15 commits into
base: feat/apex-oas
Choose a base branch
from
Draft

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

What issues does this PR fix or reference?

#, @@

Functionality Before

<insert gif and/or summary>

Functionality After

<insert gif and/or summary>

@CristiCanizales CristiCanizales self-assigned this Nov 27, 2024
@@ -120,7 +116,7 @@ export class MetadataOrchestrator {
let cursorPosition;
if (isMethodSelected) {
const editor = vscode.window.activeTextEditor;
if (editor && editor.document.fileName.endsWith('cls')) {
if (editor && editor.document.fileName.endsWith('.cls')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (editor && editor.document.fileName.endsWith('.cls')) {
if (editor?.document.fileName.endsWith('.cls')) {

});
documentContents = result[0].completion;
if (documentContents.includes('try again')) throw new Error(documentContents);
while (!documentContents.startsWith('yaml') && tries < 10) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the retries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a temporary workaround to not have to run the command multiple times until the doc is finally generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants