Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start refactoring error handling #235

Closed
wants to merge 5 commits into from
Closed

Start refactoring error handling #235

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2017 •
edited by ghost
Loading

Closes #207

  • Handle data.errors.base for client errors
  • Simplify fetch error handling (no types needed)
  • Update sagas, actions, reducers, types
  • Update tests
  • Add toplevel error handler (handle status codes as well)
  • Create resolveError logic as well
  • Update / refactor error components
  • Handle defaults only in error reducer (not anywhere else)
  • Maybe combine data/error and components

Done

  • services

@ghost ghost closed this Jun 7, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor / update reducer structure (+ actions, actionTypes, selectors, etc.)
0 participants