Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/user testing bugs #96

Merged
merged 19 commits into from
Feb 4, 2019
Merged

Fix/user testing bugs #96

merged 19 commits into from
Feb 4, 2019

Conversation

francamps
Copy link
Contributor

@francamps francamps commented Feb 1, 2019

A series of bug fixes and styling refinements are included in this PR.

  • Sources' overlay spacing issues have been fixed.
  • Tags are now called filters, and are set in different tabs as Categories. They both have new icons.
  • Movement types are optionally custom styled from config
  • Timeline has option for hard limits from config.
  • Event dots in map display color slices based on aggregate category events they contain
  • Cards display precision level for both time and location.

closes #75

@breezykermo
Copy link
Member

breezykermo commented Feb 1, 2019

A couple of things:

  • I haven't set up Travis yet, sorry. Could you run a yarn lint manually and fix any errors?
  • Do you think it makes sense to switch all tags in the code to filters? I do feel that filters are a more appropriate monikor for what we have been referring to as tags.
  • Let's put a default rangeLimits value in the initial store that is commented out, to indicate that it can be changed through 'config.js'.

@breezykermo breezykermo merged commit eafa1cb into develop Feb 4, 2019
@breezykermo breezykermo deleted the fix/user-testing-bugs branch February 4, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink switching between narratives inside narrative mode
2 participants