Skip to content
This repository was archived by the owner on Jan 27, 2025. It is now read-only.

Commit

Permalink
Inline the now-useless basicInitialize
Browse files Browse the repository at this point in the history
  • Loading branch information
DamienCassou committed Dec 12, 2016
1 parent f27d57b commit 214c4c2
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions src/object.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,19 +73,6 @@ define([], function() {
*/
my.postInitialize = function() {};

/**
* Private method handling initialization of new
* instances. Prefer overriding one of `preInitialize`,
* `initialize` or `postInitialize` instead of overriding this
* method.
*/
my.basicInitialize = function() {
var args = Array.prototype.slice.apply(arguments);
my.preInitialize.apply(this, args);
my.initialize.apply(this, args);
my.postInitialize.apply(this, args);
};

/**
* Throws an error because the method should have been overridden.
*/
Expand Down Expand Up @@ -190,7 +177,9 @@ define([], function() {
}

if (!notFinal) {
my.basicInitialize(spec);
my.preInitialize(spec);
my.initialize(spec);
my.postInitialize(spec);
}

return instance;
Expand Down

0 comments on commit 214c4c2

Please sign in to comment.