Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally allow breaking macrocycle bonds with A atom types #106

Merged
merged 1 commit into from
May 2, 2024

Conversation

diogomart
Copy link
Contributor

Some macrocycles don't have a bond between two atoms of type C, but often there's a C-A bond. For example: https://www.rcsb.org/ligand/5P8 This PR allows breaking bonds between atoms of type A, including A-A bonds, with the caveat that parameters of C will be used for A atoms of broken bonds.

@diogomart diogomart requested a review from psharma-sr April 26, 2024 15:47
Copy link
Contributor

@psharma-sr psharma-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, what I said about testing applies, assuming it works as intended it should be fine.

@diogomart
Copy link
Contributor Author

Thanks!

@diogomart diogomart merged commit 051fc50 into develop May 2, 2024
1 check passed
@diogomart diogomart deleted the macrocycle_allow_A branch May 2, 2024 22:16
diogomart added a commit that referenced this pull request Aug 14, 2024
optionally allow breaking macrocycle bonds with A atom types (re-implements #106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants