Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in _aux_altloc_mol_build #191

Merged
merged 2 commits into from
Oct 12, 2024
Merged

fix typo in _aux_altloc_mol_build #191

merged 2 commits into from
Oct 12, 2024

Conversation

rwxayheee
Copy link
Contributor

Fixed small variable name typo in _aux_altloc_mol_build

Also flipped missed and needed here

Meeko/meeko/utils/rdkitutils.py

Lines 190 to 193 in 8257379

elif has_altloc and allowed_altloc not in mols_dict:
pdbmol = None
needed_altloc = True
missed_altloc = False

@rwxayheee rwxayheee requested a review from diogomart October 11, 2024 21:45
@rwxayheee rwxayheee marked this pull request as draft October 11, 2024 22:15
@rwxayheee rwxayheee marked this pull request as ready for review October 11, 2024 22:16
diogomart
diogomart approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@diogomart diogomart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

@rwxayheee
Copy link
Contributor Author

Thank you @diogomart I will merge with 7b59498. Very very small change in variable name

@rwxayheee rwxayheee merged commit 28566ea into forlilab:develop Oct 12, 2024
1 check passed
@rwxayheee rwxayheee mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogomart diogomart diogomart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwxayheee @diogomart