-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep v0.6.0 #226
Prep v0.6.0 #226
Conversation
See above and license file
Update classifier
The Readme contained an extra repeated line, probably a typo. Removed
docs: remove extra line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks!
Would you want to put dependencies in setup.py |
I'm including as you suggest unless @nbruciaferri objects due to conflicts with conda. |
Thanks! Ringtail also needs pandas although there's no explicit |
I think a pip installation from PyPI should install dependencies. At least that's what I'm seeing for popular packages. For example, |
As long as we already checked that the packages in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, ready to merge!
Updated version strings to v0.6.0
Moved scripts to
meeko/cli
, per conda-forge requirements and already implemented in v0.5.1Removed script
mk_get_openff_epsilon_sigma.py