Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add meeko/data/params/* to MANIFEST.in #241

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

diogomart
Copy link
Contributor

it appears that basic functionality isn't working with meeko installed from pip or conda, because the JSON files with the default atom types isn't being distributed

@diogomart diogomart requested a review from rwxayheee November 14, 2024 19:34
Copy link
Contributor

@rwxayheee rwxayheee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rwxayheee rwxayheee merged commit a6d2932 into develop Nov 14, 2024
1 check passed
@rwxayheee
Copy link
Contributor

It seems like MANIFEST.in's include is not recursive. Would you like to include subdirectories in test/?

@diogomart
Copy link
Contributor Author

Good question. I don't know. It wouldn't hurt so I guess we could do it. The only scenario I can think in which that would be used is to check the installation, but having the user cd into the installation directory feels cumbersome. I can't find a way to run pytest from anywhere in the filesystem. But we should add those too, just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants