Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove from class Ring the unused attributes to reduce overhead in molecule preparation #276

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Remove from class Ring the unused attributes to reduce overhead in molecule preparation #276

merged 4 commits into from
Dec 11, 2024

Conversation

rwxayheee
Copy link
Contributor

Remove from class Ring the unused attributes: graph and corner_flip

@rwxayheee rwxayheee mentioned this pull request Dec 10, 2024
Open
@rwxayheee rwxayheee requested a review from diogomart December 11, 2024 01:50
@rwxayheee rwxayheee marked this pull request as ready for review December 11, 2024 01:52
@rwxayheee
Copy link
Contributor Author

Hi @diogomart
Thanks for adding the test! Could we merge this, or shall we hold for a bigger refactoring of rings perception?
This effectively avoids the original issue in #269

@rwxayheee rwxayheee changed the title Remove from class Ring the unused attributes, Remove from class Ring the unused attributes to reduce overhead in molecule preparation Dec 11, 2024
@rwxayheee rwxayheee linked an issue Dec 11, 2024 that may be closed by this pull request
Reduce overhead in preperation #275
Open
diogomart
diogomart approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@diogomart diogomart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to merge!

@rwxayheee
Copy link
Contributor Author

Thanks!! Merging this to develop

@rwxayheee rwxayheee merged commit 5727d7f into forlilab:develop Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogomart diogomart diogomart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce overhead in preperation
2 participants
@rwxayheee @diogomart