Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies to setup.py, or requirements.txt, or similar, if chemicalite is dropped or becomes available from PyPI #58

Closed
diogomart opened this issue Nov 6, 2024 · 5 comments
Assignees

Comments

@diogomart
Copy link
Contributor

The idea is to have a pip install from PyPI install all dependencies, but that is currently impossible because chemicalite is available only from conda-forge.

@rwxayheee
Copy link
Contributor

The dependencies are not entirely clear from README, we might want to require:

pandas

matplotlib (& ipykernel)

multiprocess (not just for MacOS, this is required on Google Linux backends)

@maylinnp
Copy link
Contributor

Updated dependencies in readme (79b6b6e), working on a forked version without chemicalite where all dependencies are now installed using the pyproject.toml.
Will wait to close this issue until that version is released.

@maylinnp maylinnp self-assigned this Dec 10, 2024
@diogomart
Copy link
Contributor Author

Opening this issue might have been a bad idea... sorry. @nbruciaferri recently said the current most popular practice is to have no dependencies listed for PyPI installation, and I think that would include pyproject.toml, and list dependencies only on the conda-forge recipe. This prevents pip from checking and enforcing dependencies and delegates all dependency management to a snake-named package manager, which are recognized to be better at package managing that pip.

@diogomart
Copy link
Contributor Author

Just PR'ed removal of dependencies from setup.py in meeko: forlilab/Meeko#274

@maylinnp
Copy link
Contributor

Gotcha, I will close this issue then. Ringtail currently does not have dependencies/requirements in setup.py, I just added it in my personal dev branch so I'll keep the pyproject.toml for a future release but remove the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants