Update formiojs version to 4.19.0 #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest stable version of
@formio/angular7.0.0 we have a hard dependency onformiojsstyles here:https://github.com/formio/angular/blob/v7.0.0/projects/angular-formio/src/components/formio/formio.component.ts#L11
It means that it doesn't matter which
formiojsversion I will use as a peer dependency in my project I will still get a styles from a version specified in your repository and they will be inlined in theFormioComponentduring build time.formio/formio.js#5447
I have this issue in my project and the long-term fix could probably be a separate loading of styles and not inlining them but so far package update may also work fine (as the local style override...but override does not look like the best solution).